group: support single reference weight vector #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naoa
force-pushed
the
group-reference-weight-vector
branch
2 times, most recently
from
5f1e2fc
to
85e7ebb
Compare
kou
reviewed
Jun 8, 2022
lib/group.c
Outdated
| @@ -756,10 +756,19 @@ grn_table_group_single_key_records_foreach_var_size_reference( | |||
| grn_io_win jw; | |||
| uint32_t value_size; | |||
| grn_id *references = grn_ja_ref(ctx, ja, value_id, &jw, &value_size); | |||
There was a problem hiding this comment.
How about renaming it to value because this may be reference + weight array?
Suggested change
| grn_id *references = grn_ja_ref(ctx, ja, value_id, &jw, &value_size); | |
| uint8_t *value = grn_ja_ref(ctx, ja, value_id, &jw, &value_size); |
lib/group.c
Outdated
| @@ -756,10 +756,19 @@ grn_table_group_single_key_records_foreach_var_size_reference( | |||
| grn_io_win jw; | |||
| uint32_t value_size; | |||
| grn_id *references = grn_ja_ref(ctx, ja, value_id, &jw, &value_size); | |||
| uint32_t n_references = value_size / sizeof(grn_id); | |||
| uint32_t element_size; | |||
| grn_bool is_weight = grn_obj_is_weight_vector_column(ctx, data->key.object); | |||
There was a problem hiding this comment.
We should use bool instead of grn_bool for newly written code. And could you use with_weight instead of is_weight because the variable name doesn't include _column or something?
Suggested change
| grn_bool is_weight = grn_obj_is_weight_vector_column(ctx, data->key.object); | |
| bool with_weight = grn_obj_is_weight_vector_column(ctx, data->key.object); |
lib/group.c
Outdated
| uint32_t i; | ||
|
|
There was a problem hiding this comment.
I like no new line here because the following for is related to this i:
Suggested change
naoa
force-pushed
the
group-reference-weight-vector
branch
from
85e7ebb
to
d239b37
Compare
|
Thanks! |
|
Thanks for your reviewing and merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.