doc: Add description about enable_apache_arrow for configure #1383
Conversation
|
Would you review of the changes so far? Would you review English of this patch when you have time? |
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
HashidaTKS
force-pushed
the
doc_add_enable_apache_arrow_to_configure
branch
from
4db3101
to
deaf748
Compare
|
I have done the following tasks in another PR #1403 because the scope is slightly different
|
|
Thank you for the review. |
doc/source/install/others.rst
Outdated
|
|
||
| .. note:: | ||
|
|
||
| If you install Apache Arrow manually, you need to the :ref:`install-others-configure-pkg-config-path` option. |
There was a problem hiding this comment.
| If you install Apache Arrow manually, you need to the :ref:`install-others-configure-pkg-config-path` option. | |
| If you install Apache Arrow into non-standard directory, you need to specify the :ref:`install-others-configure-pkg-config-path` option. |
|
Would you please re-review this? |
doc/source/install/others.rst
Outdated
| You can use ``PKG_CONFIG_PATH`` as an environment variable, but we recommend | ||
| to use it as a ``configure`` parameter because of the following reason. | ||
|
|
||
| ``configure.ac`` generates ``configure``. And when ``make`` detects that |
There was a problem hiding this comment.
configure is generated from configure.ac by GNU Autotools.
|
|
||
| .. code-block:: console | ||
|
|
||
| % ./configure PKG_CONFIG_PATH=/tmp/local/lib/pkgconfig/ |
There was a problem hiding this comment.
| % ./configure PKG_CONFIG_PATH=/tmp/local/lib/pkgconfig/ | |
| $ ./configure PKG_CONFIG_PATH=/tmp/local/lib/pkgconfig/ |
Does Pygments accept % as prompt? If yes, I'm OK with %.
FYI: Rouge that is used by Jekyll accepts only $ for prompt.
There was a problem hiding this comment.
Maybe accepted.
I couldn't find any documents about whether we can use % but I didn't get any warning about it and it seems to be displayed correctly.
There was a problem hiding this comment.
Note: $, # and % are supported: https://github.com/pygments/pygments/blob/2.13.0/pygments/lexers/shell.py#L234
|
Would you please re-review this? |
I have added descriptions about the whole build procedure with CMake. Related: #1383 Co-authored-by: Yukiko Yoshimoto <86996282+yoshimotoyuk@users.noreply.github.com>
#1382 (comment)
I have done the following tasks in another PR #1403 because the scope is slightly different