doc : Add description about apache_arrow for status command #1384
Conversation
HashidaTKS
force-pushed
the
doc_add_status_apache_arrow
branch
2 times, most recently
from
8173c53
to
27cd8d3
Compare
| * - ``apache_arrow`` | ||
| - .. versionadded:: 10.0.1 | ||
|
|
||
| The version of Apache Arrow that Groonga uses. This item only displays when Apache Arrow is valid in Groonga. |
|
@yoshimotoyuk Could you review this? |
|
@kou Would you re-review this when you have time? |
| "version": VERSION | ||
| "version": VERSION, | ||
| "features": FEATURES, | ||
| "apache_arrow": APACHE_ARROW_VERSION |
There was a problem hiding this comment.
| "apache_arrow": APACHE_ARROW_VERSION | |
| "apache_arrow": APACHE_ARROW_INFORMATION |
We may add more information later.
There was a problem hiding this comment.
Ok, I have fixed it.
| * - ``apache_arrow`` | ||
| - .. versionadded:: 10.0.1 | ||
|
|
||
| The version of Apache Arrow that Groonga uses. This item displays only when Apache Arrow is enabled in Groonga. |
There was a problem hiding this comment.
We may add not only version information but also more information later.
There was a problem hiding this comment.
Ok, I have fixed it.
| msgstr "" | ||
|
|
||
| msgid "" | ||
| "The list of features that Groonga has and whether they are enabled or not." |
There was a problem hiding this comment.
| "The list of features that Groonga has and whether they are enabled or not." | |
| "The list of Groonga's features and status(enabled or distabled)" |
Above suggestion for simple description.
If detailed description is preferred as follows;
"The list shows features of Groonga and whether they are enabled or disabled."
When you used " enabled or not " as a adjective to explain status it would be better to say " enabled or disabled".
There was a problem hiding this comment.
もし、リストに有効なものだけが出るというのであれば、言い方を変えたほうがいいので教えてください。
There was a problem hiding this comment.
ありがとうございます。リストには有効なものと無効なものどちらも出るので、この案でいかせてもらいます
| * - ``features`` | ||
| - .. versionadded:: 10.0.1 | ||
|
|
||
| The list of features that Groonga has and whether they are enabled or not. |
There was a problem hiding this comment.
is it common sense that true means "enabled" and false means "disabled"?
This is just my question...
There was a problem hiding this comment.
I think, for developers or users of Groonga, it is common sense, or at least it makes sense.
There was a problem hiding this comment.
It is very interesting. I shall remember! thank you.
Co-authored-by: Yukiko Yoshimoto <86996282+yoshimotoyuk@users.noreply.github.com>
HashidaTKS
force-pushed
the
doc_add_status_apache_arrow
branch
from
077c719
to
bf40170
Compare
|
Thanks, I have reflected the feedback. |
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
| msgstr "" | ||
|
|
||
| msgid "" | ||
| "The version information of Apache Arrow that Groonga currently uses. It's " |
There was a problem hiding this comment.
和訳の更新を忘れていたのですが、将来的にバージョン以外の情報も入るのでThe information about ...に戻そうと思います。
|
Thank you. |
#1382 (comment)