doc: Add description about drilldown.table
#1385
Conversation
HashidaTKS
force-pushed
the
doc_add_drilldown_table
branch
from
12785b5
to
14776ef
Compare
HashidaTKS
force-pushed
the
doc_add_drilldown_table
branch
from
de67051
to
431d4f7
Compare
Translate messages
| table_create Tags TABLE_PAT_KEY ShortText | ||
| # [ | ||
| # [ | ||
| # -22, |
There was a problem hiding this comment.
No, I will fix it.
There was a problem hiding this comment.
I am trying to resolve this...
Maybe this is because another example in select.rst already creates Tags table...
There was a problem hiding this comment.
I have renamed Tags to NestedDrilldownTags and Memos to NestedDrilldownMemos.
|
|
||
| .. versionadded:: 6.0.2 | ||
|
|
||
| Specifies ``${LABLE}`` of other ``drilldown``, ``drilldowns`` or ``slices``. |
There was a problem hiding this comment.
Can we specify ${LABEL} for drilldown? drilldown doesn't have its label.
There was a problem hiding this comment.
Ah, I thought we can use drilldown[${LABEL}] syntax, but now I notice it is deprecated, so I will remove drilldown from this line.
There was a problem hiding this comment.
I believe this sentence is a imperative form. And in that case, verb should be 現在形.
so would be "specify" not "specifies".
There was a problem hiding this comment.
I have fixed it.
| .. {"_key": "Rroonga", "category": "Ruby"} | ||
| .. ] | ||
| .. select Memos \ | ||
| .. --drilldowns[label_tag].keys tag \ |
There was a problem hiding this comment.
Can we use better name for label_tag?
I don't want users to use label_XXX for label.
There was a problem hiding this comment.
I have changed to simply use Tag and Category for these drilldowns table.
|
@yoshimotoyuk Could you review this? |
|
|
||
| msgid "" | ||
| "The result of the specified ``${LABLE}`` is drilldowned, which means that " | ||
| "this paramter enables nested aggregate calculations and groups in drilldown." |
There was a problem hiding this comment.
「このパラメーターを使えば多段ドリルダウンできます」とかもっとシンプルな言い回しにしませんか？
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Yukiko Yoshimoto <86996282+yoshimotoyuk@users.noreply.github.com>
Co-authored-by: Yukiko Yoshimoto <86996282+yoshimotoyuk@users.noreply.github.com>
Use breking up lines
そのように修正しました。 |
|
@yoshimotoyuk |
Co-authored-by: Yukiko Yoshimoto <86996282+yoshimotoyuk@users.noreply.github.com>
|
overall looked nice to me otherwise. :) |
|
Thank you! Would you re-review this when you have time? |
|
Thanks. |
drilldown.tableis not documented.