Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix translation procedure in i18n.rst #1407

Merged
merged 7 commits into from
Sep 12, 2022

Conversation

HashidaTKS
Copy link
Contributor

@HashidaTKS HashidaTKS commented Sep 5, 2022

Fixed the translation procedure in i18n.rst because it was obsolete.

@HashidaTKS
Copy link
Contributor Author

@kou, @yoshimotoyuk

Would you please review this when you have time?

@yoshimotoyuk
Copy link
Contributor

@HashidaTKS
I have checked Please kindly let me know if there are anything.

msgid "Repeat 2.-4. until you get good result."
msgstr "翻訳が完了するまで、2.-4.を繰り返します。"
msgid "Repeat 3.-7. until you get good result."
msgstr "翻訳が完了するまで、3.-7.を繰り返します。"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you translate ”翻訳" into good result?

Copy link
Contributor Author

@HashidaTKS HashidaTKS Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the existing translation of this document translated "翻訳" into "good result".
(I thought it was not a good translation, though...)

Okay, I will change them like below.

until you finish to translate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good fix!
Because Groonga is a search tool, a word "good result" make me think of the search result.


msgid ""
"You can update .po files by running `make update` on doc/locale/${LANGUAGE}/"
"You can update .edit files by running `make` on doc/locale/${LANGUAGE}/"
"LC_MESSAGES. (Please substitute `${LANGUAGE}` with your language code such "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"LC_MESSAGES. (Please substitute `${LANGUAGE}` with your language code such "
"LC_MESSAGES. (Please replace`${LAGUAGE}` with your language code such "

substitute is actually more to explain the role of ${LANGUAGE}.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( I do understand this is not the part of file changed, but it was bit confusing.

"There are some tools to edit .po files. .po files are just text. So you can "
"use your favorite editor. Here is a specialized editor for .po file edit "
"list."
"There are some tools to edit .po(.edit) files. .po(.edit) files are just "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"There are some tools to edit .po(.edit) files. .po(.edit) files are just "
"In order to edit .po and .edit files, there are some tools to edit. "
"Both files are just text. so you can use your favorite editor."
"Here is a list of editors specialized for editing .po(.edit) files."

I think it was bit confusing to say .po(.edit) files.. So I have fixed the whole paragraph.

Copy link
Contributor Author

@HashidaTKS HashidaTKS Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-written this paragraph.
This paragraph (this section) focuses on how to edit .edit files. So I have changed to mainly mention to .edit files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it become more easy to read!


msgid ""
"After editing .edit files, you can update .po files by running `make` on doc/"
"locale/${LANGUAGE}/LC_MESSAGES. (Please substitute `${LANGUAGE}` with your "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"locale/${LANGUAGE}/LC_MESSAGES. (Please substitute `${LANGUAGE}` with your "
"locale/${LANGUAGE}/LC_MESSAGES. (Please replace `${LANGUAGE}` with your"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@@ -240,8 +262,8 @@ msgid "How to send .po files"
msgstr ".poファイルの送り方"

msgid ""
"Please archive doc/locale/${LANGUAGE}/LC_MESSAGES/ (Please substitute "
"`${LANGUAGE}` with your language code such as 'ja'.) and send it to us! We "
"Please archive doc/locale/${LANGUAGE}/LC_MESSAGES/ (Please substitute `"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Please archive doc/locale/${LANGUAGE}/LC_MESSAGES/ (Please substitute `"
"Please archive doc/locale/${LANGUAGE}/LC_MESSAGES/ (Please replace `"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@yoshimotoyuk
Copy link
Contributor

I did not submit them...

@HashidaTKS
Copy link
Contributor Author

@yoshimotoyuk

Would you please re-review this when you have time?
Mainly about #1407 (comment).

@yoshimotoyuk
Copy link
Contributor

I added the minor comment!
Over all it looks good to me!

@HashidaTKS
Copy link
Contributor Author

@kou

Would you please review this when you have time?

@HashidaTKS
Copy link
Contributor Author

HashidaTKS commented Sep 12, 2022

I think we should unify expressions including existing sentences in this document as below.

  • doc/locale/${LANGUAGE}/LC_MESSAGES to ``doc/locale/${LANGUAGE}/LC_MESSAGES``
  • `${LANGUAGE}` to ``${LANGUAGE}``
  • 'ja' to ``ja``
  • Please substitute ... to Please replace ...

But I think these are out of scope of this patch.
How about creating an issue for it and fixing them in another PR?

@HashidaTKS
Copy link
Contributor Author

@kou

Would you please re-review this when you have time?

@kou kou merged commit 3ff9ae5 into groonga:master Sep 12, 2022
@kou
Copy link
Member

kou commented Sep 12, 2022

How about creating an issue for it and fixing them in another PR?

OK. Let's do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants