-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add news 12.0.9 #1434
Add news 12.0.9 #1434
Conversation
Would you review this when you have time? Would you review this about English when you have time? |
------------ | ||
|
||
* [:doc:`reference/functions/escalate`] Added a document for the ``escalate()`` function. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add 58e49dd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
------------ | ||
|
||
* [:doc:`reference/functions/escalate`] Added a document for the ``escalate()`` function. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add 0c1280c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
doc/source/news.rst
Outdated
This had occured when using :ref:`select-n-workers` with a value greater than ``1`` and ``drilldowns[{LABEL}].filter`` at the same time. | ||
|
||
This was because referencing incorrect values when performing internal parallel processing. | ||
So if the condition above was satisfied, Groonga sometimes crashed depending on the timing of the parallel processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
もしクラッシュしなかった場合、ドリルダウンの結果は正しい結果になるんでしたっけ?
もし、ならないならそのことも書いておいた方がよいと思います。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
理屈から考えて不正な結果を返す場合もありそうだったので、その旨も記載しました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you confirm my comments?
Thanks, I have addressed your comments. |
Could you list it as an experimental feature? |
aba555e
to
e6b425f
Compare
Sure, I have added a description about NormalizerHTML as an experimental feature. |
doc/source/news.rst
Outdated
This was because referencing incorrect values (objects) when performing internal parallel processing. | ||
So if the condition above was satisfied, Groonga sometimes crashed or returned incorrect results depending on the timing of the parallel processing. | ||
|
||
* Suppressed logging a lot of same messages when no memory available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not a bug.
Because it is not abnormaly that Groonga output a lot of same messages when no memory available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to Improvement.
|
||
In this sample, ``&`` and ``&`` are unescaped to ``&``. | ||
|
||
* [httpd] Updated bundled nginx to 1.23.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update include security bug fix.
Therefore, we should also add about security bug fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
日本語の「これは」の感覚で「This」に置き換えると少し違和感があります。
どのThis?という気持になるので「この機能」や「この修正」などにしたほうが分かりやすくなると思います。
doc/source/news.rst
Outdated
|
||
* [:doc:`reference/normalizers`] Added NormalizerHTML. (Experimental) | ||
|
||
This is a normalizer for HTML. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of "This", the subject would be better to be more explaining such as this function or normalizerHTML, self.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
doc/source/news.rst
Outdated
|
||
This had occured when using :ref:`select-n-workers` with a value greater than ``1`` and ``drilldowns[{LABEL}].filter`` at the same time. | ||
|
||
This was because referencing incorrect values (objects) when performing internal parallel processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here when using " this " as the subject it would be nice to add the main word.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
完全に日本語の「これは」の感覚で使っていたので、ご指摘の通り修正しました。 |
Thank you, I have addressed your comments. |
Co-authored-by: Yukiko Yoshimoto <86996282+yoshimotoyuk@users.noreply.github.com>
Co-authored-by: Yukiko Yoshimoto <86996282+yoshimotoyuk@users.noreply.github.com>
50c4a7e
to
f01086a
Compare
No description provided.