packages: download latest source archive in dist task #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Nov 14, 2022
Comment on lines
45
to
49
| desc "Download the latest source archive" | ||
| task :source do | ||
| source_archive_url = built_package_url(nil, @archive_base_name) | ||
| download(source_archive_url, "..") | ||
| end |
There was a problem hiding this comment.
Can we rewrite define_archive_task instead?
There was a problem hiding this comment.
Adressed. (Also changed the description of this PR.)
kou
reviewed
Nov 14, 2022
packages/Rakefile
Outdated
Comment on lines
45
to
46
| source_archive_url = built_package_url(nil, @archive_base_name) | ||
| download(source_archive_url, "..") |
There was a problem hiding this comment.
If we write this here, this is always processed. (rake --help also processes this.)
We should put this into file do ... end.
There was a problem hiding this comment.
Fixed. (I had misunderstand about file ... do ... end... )
HashidaTKS
changed the title
when we execute "cd packages && rake source", we download the latest source archive into the top of the repository.
HashidaTKS
force-pushed
the
download-source-from-rake
branch
from
7463eed
to
28536dc
Compare
|
Would you re-review this PR? |
|
How about this? diff --git a/packages/Rakefile b/packages/Rakefile
index bc7939453..7c5704cfc 100644
--- a/packages/Rakefile
+++ b/packages/Rakefile
@@ -42,9 +42,14 @@ class GroongaPackageTask < PackagesGroongaOrgPackageTask
end
def define_archive_task
- file @original_archive_name do
- File.symlink("../#{@original_archive_name}",
- @original_archive_name)
+ file "../#{@original_archive_name}" do
+ source_archive_url = built_package_url(:source, @archive_base_name)
+ download(source_archive_url, "..")
+ end
+
+ file @original_archive_name => "../#{@original_archive_name}" do
+ ln_s("../#{@original_archive_name}",
+ @original_archive_name)
end
end
|
|
Thanks, I have changed the code as you indicated, and it worked fine as far as I tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By this change, we can download the latest source archive from the github release page into the top of the repository by executing "cd packages && rake dist".