Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add news for 12.1.1 #1475

Merged
merged 26 commits into from
Jan 6, 2023
Merged

doc: add news for 12.1.1 #1475

merged 26 commits into from
Jan 6, 2023

Conversation

HashidaTKS
Copy link
Contributor

@HashidaTKS HashidaTKS commented Dec 22, 2022

Add news for 12.1.1

Add description about drilldown bug
Add description about NormalizerTable bug
Modify the description about key_vector_expansion/power_set
@HashidaTKS
Copy link
Contributor Author

HashidaTKS commented Jan 5, 2023

@kou @komainu8

日本語の段階で一度レビューを頂けないでしょうか?

@yoshimotoyuk

上記のレビュー完了後、 news.rst の未翻訳部分について翻訳して頂けないでしょうか?

@@ -5,6 +5,375 @@
News
====

.. _release-12-1-1:

Release 12.1.1 - 2022-12-29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Release 12.1.1 - 2022-12-29
Release 12.1.1 - 2023-01-06

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました。

doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
doc/source/news.rst Outdated Show resolved Hide resolved
HashidaTKS and others added 6 commits January 6, 2023 12:26
Co-authored-by: Horimoto Yasuhiro <horimoto@clear-code.com>
Co-authored-by: Horimoto Yasuhiro <horimoto@clear-code.com>
Co-authored-by: Horimoto Yasuhiro <horimoto@clear-code.com>
@HashidaTKS
Copy link
Contributor Author

@yoshimotoyuk

指摘事項等更新しましたので、現状のnews.rstで翻訳をお願いします!

@HashidaTKS HashidaTKS marked this pull request as ready for review January 6, 2023 09:36
@HashidaTKS
Copy link
Contributor Author

本文に適用し、typo等の細かな部分を直しました。

# ]

``--match_columns "contents[1]"`` specifies only 2nd vector elements of ``contents`` as the search target.
In this sample, ``["I like Groonga", "Use Groonga with Ruby"]`` is shown in the results because 2nd element ``Ruby`` is in ``Use Groonga with Ruby``. However, ``["I like Ruby", "Use Groonga"]`` is not shown in results because 2nd element ``Ruby`` is not in ``Use Groonga``.
Copy link
Contributor Author

@HashidaTKS HashidaTKS Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2nd element ``Ruby`` is in ``Use Groonga with Ruby`` の部分が構文解析できないのですが、以下のような感じではどうでしょうか?

Suggested change
In this sample, ``["I like Groonga", "Use Groonga with Ruby"]`` is shown in the results because 2nd element ``Ruby`` is in ``Use Groonga with Ruby``. However, ``["I like Ruby", "Use Groonga"]`` is not shown in results because 2nd element ``Ruby`` is not in ``Use Groonga``.
In this sample, ``["I like Groonga", "Use Groonga with Ruby"]`` is shown in the results because ``Ruby`` is in 2nd element ``Use Groonga with Ruby``. However, ``["I like Ruby", "Use Groonga"]`` is not shown in results because ``Ruby`` is not in 2nd element ``Use Groonga``.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、一旦上記の変更を入れてマージしてしまいました。
もしこれではおかしい、ということであればご指摘頂ければ後ほど反映します。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなってすみません。
2nd element = Use Groonga with Ruby
であればOKです
が私の認識では
2nd element= Ruby だったので、最初の語順になってました。
2要素目はRubyで、Rubyが、Use Groongaに入っていないから結果に表示されないという理解でしたがちがいましたか?

Copy link
Contributor Author

@HashidaTKS HashidaTKS Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2nd element = Use Groonga with Ruby の意図でした!

["I like Groonga", "Use Groonga with Ruby"] の第一要素が I like Groonga で、第二要素が Use Groonga with Ruby という感じです。
["I like Ruby", "Use Groonga"] についても同様に 第一要素が I like Ruby、第二要素が Use Groonga です。

Ruby という単語が、 ["I like Groonga", "Use Groonga with Ruby"] の第二要素には入っているけれども、 ["I like Ruby", "Use Groonga"] の第二要素には入っていないので、 ["I like Ruby", "Use Groonga"] は結果には表示されない、という感じです!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

それであれば大丈夫です。
element という事だったので「1ワード」かなと思ってしましました。
難しいですね・・・

@HashidaTKS HashidaTKS changed the title [WIP] doc: add news for 12.1.1 doc: Jan 6, 2023
@HashidaTKS HashidaTKS merged commit a6ab961 into master Jan 6, 2023
@HashidaTKS HashidaTKS deleted the add-news-for-12.1.1 branch January 6, 2023 09:59
@HashidaTKS HashidaTKS changed the title doc: doc: add news for 12.1.1 Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants