Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add bootstrap.js/css into files.am #1484

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Conversation

HashidaTKS
Copy link
Contributor

@HashidaTKS HashidaTKS commented Jan 11, 2023

bootstrap.js and bootstrap.css are necessary to the latest document site.
They are copied (moved) into result files of make update-document by adding them into files.am.

The reason why we need to add bootstrap.js and bootstrap.css is because pydata-sphinx-theme split bootstrap and theme styling.

pydata/pydata-sphinx-theme#994

@HashidaTKS
Copy link
Contributor Author

@kou @komainu8

Would you review this when you have time?

@komainu8
Copy link
Member

+1

BTW, why do this modification to be become necessary?
Is it because the documentation was generated with Sphinx 6.0.x?

@HashidaTKS
Copy link
Contributor Author

BTW, why do this modification to be become necessary?
Is it because the documentation was generated with Sphinx 6.0.x?

Because pydata-sphinx-theme split bootstrap and theme styling.

pydata/pydata-sphinx-theme#994

@komainu8
Copy link
Member

I see.
Could you add this reason to commit message?

@HashidaTKS
Copy link
Contributor Author

Could you add this reason to commit message?

Sure, I have added.

@kou kou merged commit 068d783 into master Jan 12, 2023
@kou kou deleted the doc-add-bootstrap-files branch January 12, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants