Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NormalizerNFKC: rename unify_katakana_z_sounds to unify_katakana_zu_small_sounds #1512

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

HashidaTKS
Copy link
Contributor

@HashidaTKS HashidaTKS commented Feb 3, 2023

It's for consistency with unify_katakana_du_small_sounds.

@kou
Copy link
Member

kou commented Feb 3, 2023

Could you use zu_small_sounds?

@HashidaTKS HashidaTKS changed the title NormalizerNFKC: rename unify_katakana_z_sounds to unify_katakana_zu_sounds NormalizerNFKC: rename unify_katakana_z_sounds to unify_katakana_zu_small_sounds Feb 3, 2023
@HashidaTKS
Copy link
Contributor Author

Could you use zu_small_sounds?

Sure, I have renamed.

lib/normalizer.c Outdated
Comment on lines 1481 to 1483
const unsigned char *start,
const unsigned char *current,
const unsigned char *end,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you indent parameters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@kou kou merged commit f4ee38a into master Feb 6, 2023
@kou kou deleted the rename-z-sounds-to-zu-sounds branch February 6, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants