NormalizerNFKC: rename unify_katakana_g_sounds to unify_katakana_gu_small_sounds
#1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you review this when you have time_ |
|
Could you use |
HashidaTKS
force-pushed
the
rename-g-sounds-to-gu-sounds
branch
from
9030661
to
1eeaa11
Compare
Sure, I have renamed. |
kou
reviewed
Feb 6, 2023
lib/normalizer.c
Outdated
| @@ -1707,7 +1707,7 @@ grn_nfkc_normalize_unify_katakana_di_sound(grn_ctx *ctx, | |||
| } | |||
|
|
|||
| static const unsigned char * | |||
| grn_nfkc_normalize_unify_katakana_g_sounds(grn_ctx *ctx, | |||
| grn_nfkc_normalize_unify_katakana_gu_small_sounds(grn_ctx *ctx, | |||
| const unsigned char *start, | |||
There was a problem hiding this comment.
We need our formatter configuration and a lint CI job...
kou
changed the title
unify_katakana_g_sounds to unify_katakana_gu_soundsunify_katakana_g_sounds to unify_katakana_gu_small_sounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's for consistency with
unify_katakana_du_small_sounds.