Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc normalizers: Add description about newly added options #1542

Merged
merged 11 commits into from
Mar 13, 2023

Conversation

HashidaTKS
Copy link
Contributor

@HashidaTKS HashidaTKS commented Mar 8, 2023

Add description about the following options.

unify_katakana_gu_small_sounds
unify_katakana_di_sound
unify_katakana_wo_sound
unify_katakana_zu_small_sounds
unify_katakana_du_sound
unify_katakana_trailing_o
unify_katakana_du_small_sounds
unify_kana_prolonged_sound_mark
unify_kana_hyphen

@HashidaTKS
Copy link
Contributor Author

We need to add similar description for token_filters, but I think it is better to work about it in another PR.

@HashidaTKS
Copy link
Contributor Author

HashidaTKS commented Mar 8, 2023

I feel like the description about options shoud be unified into a single page because all NormalizerNFKC* uses the same options...
Adding similar descriptions for each normalizerNFKCs makes writing and reviewing difficult...

@HashidaTKS HashidaTKS marked this pull request as ready for review March 8, 2023 10:09
@kou
Copy link
Member

kou commented Mar 8, 2023

It makes sense.

@komainu8 komainu8 merged commit 7f011b8 into master Mar 13, 2023
@komainu8 komainu8 deleted the doc-add-normalizer-options branch March 13, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants