Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding conditional directives that split up parts of statements. #438

Closed
wants to merge 1 commit into from
Closed

Avoiding conditional directives that split up parts of statements. #438

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 29, 2015

A suggestion to compile entire statements and expressions, as suggested by code style guidelines from the Linux Kernel and practitioners.

It might improve code understanding, maintainability and error-proneness.

@s-yata
Copy link
Contributor

s-yata commented Nov 30, 2015

Thank you!
It looks nice to me, but I think this patch should be first applied to the master of nginx ( https://github.com/nginx/nginx ).

@kou
Copy link
Member

kou commented Nov 30, 2015

We'll merge the change when nginx merges them.
So I close this issue.

FYI: nginx accepts patches on mailing list: http://mailman.nginx.org/mailman/listinfo/nginx-devel

@kou kou closed this Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants