Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md to mention adding a worker (and the charges that will result) #150

Open
Faeranne opened this issue Aug 14, 2015 · 4 comments

Comments

@Faeranne
Copy link
Contributor

With worker.js, the minimum cost to test the app is now $32, since worker needs it's own dynamo. We should point this out in the README/testing documentation, since this will require adding a credit card.

@openjck
Copy link
Contributor

openjck commented Aug 14, 2015

Nice catch. At the moment, README.md mainly focuses on using Discord and TESTING.md mainly focuses on running unit and code quality tests. Would CONTRIBUTING.md be a good place for this? We have a note here but could always expand that explanation.

@Faeranne
Copy link
Contributor Author

Right, but the redis doesn't cause a charge, the dynamo will result in a
charge, and would require making sure the dynamos are shutdown after
testing, less they charge the full $32.
CONTRIBUTING.md makes sense, since that is where the link for PR and Issues
goes.

On Fri, Aug 14, 2015, 12:58 John Karahalis notifications@github.com wrote:

Nice catch. At the moment, README.md mainly focuses on using Discord
and TESTING.md mainly focuses on running unit and code quality tests.
Would CONTRIBUTING.md be a good place for this? We have a note here
9c98eb2#diff-6a3371457528722a734f3c51d9238c13R14
but could always expand that explanation.


Reply to this email directly or view it on GitHub
#150 (comment).


Q: Why is this email five sentences or less?
A: http://five.sentenc.es

@openjck
Copy link
Contributor

openjck commented Aug 14, 2015

Ah, good point. A credit card number is required when installing Redis (for verification) but the charges are different. Sounds good to me.

@openjck
Copy link
Contributor

openjck commented Aug 14, 2015

I think we neglect to mention scaling up a worker, too. We could add both those notes in one PR.

@openjck openjck changed the title Update README.MD to reflect the credit card requirement. Update CONTRIBUTING.md to mention adding a worker (and the charges that will result) Aug 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants