Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in AbstractToolsMojo.initializeProperties when enabling bindSessionUserOverrideProperties #203

Closed
sebthom opened this issue Nov 12, 2021 · 3 comments · Fixed by #204
Closed

NPE in AbstractToolsMojo.initializeProperties when enabling bindSessionUserOverrideProperties #203

sebthom opened this issue Nov 12, 2021 · 3 comments · Fixed by #204
Assignees
@keeganwitt
Labels
Bug
Milestone
1.13.1

Comments

@sebthom
Copy link

sebthom commented Nov 12, 2021

To access maven property values that were overridden on the command line I enabled:

<bindAllProjectProperties>true</bindAllProjectProperties>
<bindSessionUserOverrideProperties>true</bindSessionUserOverrideProperties>

The moment I do this and run my build I get the following exception:

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.gmavenplus:gmavenplus-plugin:1.13.0:execute (compile) on project jstuff-parent: Execution compile of goal org.codehaus.gmavenplus:gmavenplus-plugin:1.13.0:execute failed.            
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)                                                                                                                                                                                           
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)                                                                                                                                                                                           
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)                                                                                                                                                                                           
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)                                                                                                                                                                  
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)                                                                                                                                                                   
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)                                                                                                                                                     
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)                                                                                                                                                                                   
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)                                                                                                                                                                                                            
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)                                                                                                                                                                                                            
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)                                                                                                                                                                                                              
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)                                                                                                                                                                                                                  
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)                                                                                                                                                                                                                   
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)                                                                                                                                                                                                                     
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)                                                                                                                                                                                                      
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)                                                                                                                                                                                    
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)                                                                                                                                                                            
    at java.lang.reflect.Method.invoke (Method.java:566)                                                                                                                                                                                                                          
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)                                                                                                                                                                                       
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)                                                                                                                                                                                               
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)                                                                                                                                                                                     
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)                                                                                                                                                                                                 
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution compile of goal org.codehaus.gmavenplus:gmavenplus-plugin:1.13.0:execute failed.                                                                                                                           
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:148)                                                                                                                                                                         
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)                                                                                                                                                                                           
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)                                                                                                                                                                                           
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)                                                                                                                                                                                           
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)                                                                                                                                                                  
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)                                                                                                                                                                   
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)                                                                                                                                                     
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)                                                                                                                                                                                   
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)                                                                                                                                                                                                            
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)                                                                                                                                                                                                            
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)                                                                                                                                                                                                              
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)                                                                                                                                                                                                                  
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)                                                                                                                                                                                                                   
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)                                                                                                                                                                                                                     
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)                                                                                                                                                                                                      
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)                                                                                                                                                                                    
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)                                                                                                                                                                            
    at java.lang.reflect.Method.invoke (Method.java:566)                                                                                                                                                                                                                          
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)                                                                                                                                                                                       
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)                                                                                                                                                                                               
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)                                                                                                                                                                                     
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)                                                                                                                                                                                                 
Caused by: java.lang.NullPointerException                                                                                                                                                                                                                                         
    at java.util.concurrent.ConcurrentHashMap.putVal (ConcurrentHashMap.java:1011)                                                                                                                                                                                                
    at java.util.concurrent.ConcurrentHashMap.put (ConcurrentHashMap.java:1006)                                                                                                                                                                                                   
    at java.util.Properties.put (Properties.java:1340)                                                                                                                                                                                                                            
    at org.codehaus.gmavenplus.mojo.AbstractToolsMojo.initializeProperties (AbstractToolsMojo.java:188)                                                                                                                                                                           
    at org.codehaus.gmavenplus.mojo.ExecuteMojo.setupShell (ExecuteMojo.java:181)                                                                                                                                                                                                 
    at org.codehaus.gmavenplus.mojo.ExecuteMojo.doExecute (ExecuteMojo.java:139)                                                                                                                                                                                                  
    at org.codehaus.gmavenplus.mojo.ExecuteMojo.execute (ExecuteMojo.java:90)                                                                                                                                                                                                     
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)                                                                                                                                                                         
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)                                                                                                                                                                                           
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)                                                                                                                                                                                           
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)                                                                                                                                                                                           
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)                                                                                                                                                                  
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)                                                                                                                                                                   
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)                                                                                                                                                     
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)                                                                                                                                                                                   
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)                                                                                                                                                                                                            
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)                                                                                                                                                                                                            
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)                                                                                                                                                                                                              
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)                                                                                                                                                                                                                  
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)                                                                                                                                                                                                                   
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)                                                                                                                                                                                                                     
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)                                                                                                                                                                                                      
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)                                                                                                                                                                                    
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)                                                                                                                                                                            
    at java.lang.reflect.Method.invoke (Method.java:566)                                                                                                                                                                                                                          
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)                                                                                                                                                                                       
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)                                                                                                                                                                                               
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)                                                                                                                                                                                     
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)

When I set bindSessionUserOverrideProperties to false the NPE does not occur.
keeganwitt added a commit that referenced this issue Nov 13, 2021
@keeganwitt
Check that user property exists before adding to properties (fixes #203)
88e71cc
@keeganwitt
Copy link
Member

keeganwitt commented Nov 13, 2021 •
edited

Thanks for reporting this! I think I missed a null check (doh!).

Can you do me a favor and verify this is fixed with 1.13.1-SNAPSHOT? It's published at the repo below, if you don't already have that one configured.

<repository>
  <id>sonatype-oss-snapshots</id>
  <url>https://oss.sonatype.org/content/repositories/snapshots</url>
  <releases>
	<enabled>false</enabled>
  </releases>
  <snapshots>
	<enabled>true</enabled>
	<updatePolicy>always</updatePolicy>
	<checksumPolicy>warn</checksumPolicy>
  </snapshots>
</repository>

keeganwitt added a commit that referenced this issue Nov 13, 2021
@keeganwitt
Check that user property exists before adding to properties
b662879 
(fixes #203)
@keeganwitt keeganwitt mentioned this issue Nov 13, 2021
Merged
@keeganwitt keeganwitt self-assigned this Nov 13, 2021
@keeganwitt keeganwitt added this to the 1.13.1 milestone Nov 13, 2021
@keeganwitt keeganwitt added the Bug label Nov 13, 2021
@sebthom
Copy link
Author

sebthom commented Nov 23, 2021 •
edited

@keeganwitt Works for me. Thanks!

I would really appreciate if you could release 1.13.1 with the fix included soon.

@keeganwitt
Copy link
Member

Thank you for verifying. It's available now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keeganwitt keeganwitt

Labels
Bug
Projects
None yet
Milestone
1.13.1
Development

Successfully merging a pull request may close this issue.

Check that user property exists before adding to properties groovy/GMavenPlus
2 participants
@keeganwitt @sebthom