Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to use multiple Java and Groovy versions #267

Closed
bmarwell opened this issue Sep 25, 2023 · 4 comments
Closed

Update CI to use multiple Java and Groovy versions #267

bmarwell opened this issue Sep 25, 2023 · 4 comments

Comments

@bmarwell
Copy link
Contributor

The CI could be updated to a newer setup-java action which includes:

  • Java 11
  • Java 21 (no 17 -- if it works on 21, it is fine, too!)
  • Groovy 4.0.0 (earliest version, Java 11 only)
  • Groovy 4.0.11 (first to support Java 21)
  • Latest Groovy

Maybe enhance some parameters (memory, no-transfer-progress), etc.

WDYT?

@keeganwitt
Copy link
Member

I haven't really seen many problems with Java versions to make that worth adding time to the builds for (or complexity of cros-product) IMO. So, I'd probably say just test with whatever is the latest LTS.

I think we should have a test for the latest of each major version of Groovy still supported by the team. At the time of writing, that would be

  • 2.5.23
  • 3.0.19
  • 4.0.15
  • 5.0.0-alpha-2

@bmarwell
Copy link
Contributor Author

Can try with two versions (latest 3.x and latest 4.x).
However, the latest 3.x groovy doesn't support Java 21 nor Java 17. Would need to use 11 for that.

@keeganwitt
Copy link
Member

Can try with two versions (latest 3.x and latest 4.x). However, the latest 3.x groovy doesn't support Java 21 nor Java 17. Would need to use 11 for that.

Ah, good point. Maybe we just do 11 across the board.

bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Sep 25, 2023
@bmarwell
Copy link
Contributor Author

Fixed on 981d4e7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants