Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groovy7001 #500

Closed
wants to merge 2 commits into from
Closed

Groovy7001 #500

wants to merge 2 commits into from

Conversation

paulk-asert
Copy link
Member

No description provided.

@paulk-asert
Copy link
Member Author

Don't merge as is. Needs discussion as to whether the commented out method signature changes can be supported. Also needs more tests. Also, given that some of the commented out signatures are similar to ones that seem to work, we need to explore whether our test coverage is lacking in a few cases.

@paulk-asert
Copy link
Member Author

Also, groovydoc and docgenerator need to be updated (though changes are obviously needed regardless of this PR).

Javadoc shows method entries like this:

static <T,E,C extends Collection<T>> C collect(Collection<E> self, C collector, Closure<? extends T> transform)
static <K,V,E,M extends Map<K,V>> M collectEntries(E[] self, M collector)

Groovydoc shows method entries like this (type parameter declarations missing):

static C collect(Collection<E> self, C collector, Closure<? extends T> transform)
static M collectEntries(E[] self, M collector)

groovy-jdk shows method entries like this (type parameter declarations missing and type parameters converted to Object):

Object collect(Object collector, Closure transform)
Object collectEntries(Object collector)

@paulk-asert
Copy link
Member Author

Other work in the new repo has superseded this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant