Fix didn't load zh_TW & zh_HK issue #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
May 24, 2019
lib/i18n_data.rb
Outdated
| @@ -57,6 +57,8 @@ def fetch(type, language_code) | |||
| def normal_to_region_code(normal) | |||
| { | |||
| "ZH" => "zh_CN", | |||
| "ZH-HK" => "zh_HK", | |||
| "ZH-TW" => "zh_TW", | |||
There was a problem hiding this comment.
- this hash should be a constant
- don't map these 1-off translations but use
.tr('-', '_')so it works for everything - add a test
There was a problem hiding this comment.
Hi @grosser , thank you for your reply, I already add a test and update the PR,
but I'm not familiar with Travis CI, would you help how to pass the test ? Thank you.
|
try |
|
@pominx Does this issue still cause you trouble? What happens if you rebase this on the default branch of this repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rails, I18n.locale is "zh-TW" & "zh-HK", which would not look into correct file in:
https://github.com/grosser/i18n_data/blob/master/lib/i18n_data.rb#L24
because "zh-TW" would not become "ZH_TW" (dash to underline).
Just let
I18nData.countries('ZH_TW')can get correct data.