Use parent's run method when running specs. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In running the original method with this gem, RSpec::Core::World#example_counts has to return divided number with process size. So added a monkey patch for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I want to apply the suite hooks to
run_group_of_tests. In order to do so, I think it's better to use the originalrunmethod than copying from the parent class because the implementation of the method can be different in each version of RSpec.In running the original
runwith this gem,RSpec::Core::World#example_countshas to return divided number with process size. So added a monkey patch (core_ext/rspec_world.rb).