use egrep to make it possible to use regexp #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A test would be great, but it looks like it should work... |
grosser
added a commit
that referenced
this pull request
Oct 18, 2012
use egrep to make it possible to use regexp
|
0.2.5 |
|
Yes a test would be great. I looked into the specs but you never tested that method, only mocked it. It is possible to write a test that forks a process first with a unique id and test for the correct process ids. |
|
If you are curious enough go ahead and try to build it, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have one server that also serves a redmine which is using Rails 2.x, so we need to match against Rack and Rails. Using Regexp this is very easy :)