Added missing newlines to EOF in several public headers. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When imported in a project with GCC_WARN_ABOUT_MISSING_NEWLINE = YES, a couple of headers would fail on this warning. Also enabled this warning in the local project for verification.
groue
added a commit
that referenced
this pull request
Apr 10, 2014
Added missing newlines to EOF in several public headers.
|
Thanks, Ben! I don't quite know if it deserves a new version, what do you think? |
|
Thanks Gwendal! (this was my first effort at a Github PR, and apparently successful, yay!) I agree; it's a pretty minor thing so I don't think it calls for a new version. It was easy for me to work around locally by just disabling that warning for now in my release build. b |
|
You are welcome :-) Your code will ship in the next release. Happy github and happy Mustache! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When imported in a project with GCC_WARN_ABOUT_MISSING_NEWLINE = YES, a couple of headers would fail on this warning. Also enabled this warning in the local project for verification.
(I discovered this with GRMustache brought in via CocoaPods and running a production build with a set of strict warnings enabled.)