Snowflake Keypair App #2537
Snowflake Keypair App #2537
Conversation
evantahler
force-pushed
the
180237226-snowflake-pem-app
branch
from
3142861
to
70a2417
Compare
ui/ui-config/pages/app/new/index.tsx
Outdated
| export default function Page(props) { | ||
| const { | ||
| errorHandler, | ||
| apps, | ||
| plugins, | ||
| availablePlugins, | ||
| installedPlugins, | ||
| }: { | ||
| errorHandler: ErrorHandler; | ||
| apps: Actions.AppOptions["types"]; | ||
| plugins: Actions.PluginsAvailableList["plugins"]; | ||
| installedPlugins: Actions.AppOptions["plugins"]; | ||
| availablePlugins: Actions.PluginsAvailableList["plugins"]; | ||
| } = props; |
There was a problem hiding this comment.
I think this change helps clarify what's happening on this page - we actually listing plugins that provide apps (some installed, some that could be installed). We aren't listing apps.
There was a problem hiding this comment.
Nice! Adding new apps with different options seems pretty smooth!
One thing that I kept thinking about when going through this is the fact that we have two actions that return available plugins, and they are oftentimes combined: plugins:available:list and now app:options. Not exactly sure if there's anything to do about it yet since they do return different things for each plugin, but maybe something to keep an eye out for.
On the Snowflake side: do we need to add some tests for this new app auth method?
|
#2543 will be merged here |
* App and Plugin Action Cleanup * update notifier test and types * UI cleanup * Update ui/ui-components/components/AppSelectorList.tsx Co-authored-by: Pedro S. Lopez <pedro.lopez@grouparoo.com> Co-authored-by: Pedro S. Lopez <pedro.lopez@grouparoo.com>
* Snowflake Keypair App * fixup bad types * fix dev GROUPAROO_RUN_MODE ovveride * AppSlector can make next item directly * cleanup + new headers * fix test * log * more saftey around preview * remove unused * App and Plugin Action Cleanup (#2543) * App and Plugin Action Cleanup * update notifier test and types * UI cleanup * Update ui/ui-components/components/AppSelectorList.tsx Co-authored-by: Pedro S. Lopez <pedro.lopez@grouparoo.com> Co-authored-by: Pedro S. Lopez <pedro.lopez@grouparoo.com> * remove extra router arg Co-authored-by: Pedro S. Lopez <pedro.lopez@grouparoo.com>
Creates a new
snowflake-keypairapp to allow connecting to Snowflake databases with keypair authentication rather than password authentication.snowflakeand this new one issnowflake-keypairThis PR also makes the selection process better when adding a new App, Source, or Destination. If there is more than one option for the Plugin or App you selected, you'll be taken to a chooser page. If not, we'll make the item for you and take you to the edit page directly
Closes #2532
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review