refactor: indexable base #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and delete UserData type, using APIUser instead
because `avatar` was a property of UserData and `avatar_url` is a property of APIUser BREAKING CHANGE: User constructor no longer accepts `avatar` property; use `avatar_url` instead
first argument is now `client` to match other subclasses of `Base` BREAKING CHANGE: Channel constructor changed: `Channel(ChannelData)` -> `Channel(Client, ChannelData)`
`Message` -> `Message<T extends Channel>`
todo: fix the unsafe type assertion
todo: fix the unsafe type assertion
because this is different from User#avatar_url and I didn't know that at the time
(and extend `Base`)
this makes managers generic on their held data types AND the held data type's constructor. Also replaces the Indexable interface with the Base class, so BaseManager is now generic on Base instead of Indexable
striker4150
suggested changes
May 23, 2022
| @@ -27,7 +30,7 @@ export default class FormerGroupManager extends BaseManager<FormerGroup> impleme | |||
| const user = this.client.users._upsert( | |||
| new User(this.client, { | |||
| id: data.user_id, | |||
| avatar: data.image_url, | |||
| avatar_url: data.image_url, | |||
There was a problem hiding this comment.
data.image_url is of type string | null, while avatar_url is of type string. This type error occurs in several places: FormerGroupManager.ts, GroupManager.ts, Message.ts, and Relationship.ts.
There was a problem hiding this comment.
oh right, that's because I updated some stuff in the types repo and forgot to push those changes sorry
missed this one somehow the first time around
including groupme-api-types@2.0.0
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a massive overhaul with a number of huge refactoring changes:
Baseclass with_clone()and_patch()methods which all other structures extendBaserather thanIndexable