Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: indexable base #99

Merged
merged 17 commits into from
May 27, 2022
Merged

refactor: indexable base #99

merged 17 commits into from
May 27, 2022

Commits on May 22, 2022

  1. refactor: 🏗️ add Base class

    @not-so-smart
    not-so-smart committed May 22, 2022
    Configuration menu
    Copy the full SHA
    1b64ce1 View commit details
    Browse the repository at this point in the history

  2. refactor(Relationship): 🏗️ extend Base

    @not-so-smart
    not-so-smart committed May 22, 2022
    Configuration menu
    Copy the full SHA
    e8d78a6 View commit details
    Browse the repository at this point in the history

  3. refactor(User): 🏗️ extend Base 

    and delete UserData type, using APIUser instead
    @not-so-smart
    not-so-smart committed May 22, 2022
    Configuration menu
    Copy the full SHA
    a8d2ac9 View commit details
    Browse the repository at this point in the history

  4. refactor(User): ♻️ rename avatar to avatar_url in User constructors 

    because `avatar` was a property of UserData and `avatar_url` is a property of APIUser

BREAKING CHANGE: User constructor no longer accepts `avatar` property; use `avatar_url` instead
    @not-so-smart
    not-so-smart committed May 22, 2022
    Configuration menu
    Copy the full SHA
    1e5c629 View commit details
    Browse the repository at this point in the history

  5. refactor(User): ♻️ replace UserData type with APIUser

    @not-so-smart
    not-so-smart committed May 22, 2022
    Configuration menu
    Copy the full SHA
    a38b557 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. refactor(Channel): 🏗️ extend Base, update constructor signature 

    first argument is now `client` to match other subclasses of `Base`

BREAKING CHANGE: Channel constructor changed:
`Channel(ChannelData)` -> `Channel(Client, ChannelData)`
    @not-so-smart
    not-so-smart committed May 23, 2022
    Configuration menu
    Copy the full SHA
    e5feacb View commit details
    Browse the repository at this point in the history

  2. refactor(Channel): 🧑‍💻 add dataFromGroup and dataFromChat static … 

    …utility methods
    @not-so-smart
    not-so-smart committed May 23, 2022
    Configuration menu
    Copy the full SHA
    6e7479c View commit details
    Browse the repository at this point in the history

  3. refactor(Message): 🏗️ extend Base, make Message generic on Channel 

    `Message` -> `Message<T extends Channel>`
    @not-so-smart
    not-so-smart committed May 23, 2022
    Configuration menu
    Copy the full SHA
    90e8c91 View commit details
    Browse the repository at this point in the history

  4. feat(Base): 💩 implement BaseGroup#_patch 

    todo: fix the unsafe type assertion
    @not-so-smart
    not-so-smart committed May 23, 2022
    Configuration menu
    Copy the full SHA
    7641639 View commit details
    Browse the repository at this point in the history

  5. feat(Base): 💩 implement Chat#_patch 

    todo: fix the unsafe type assertion
    @not-so-smart
    not-so-smart committed May 23, 2022
    Configuration menu
    Copy the full SHA
    1a86da5 View commit details
    Browse the repository at this point in the history

  6. refactor(Member): 🏗️ extend Base

    @not-so-smart
    not-so-smart committed May 23, 2022
    Configuration menu
    Copy the full SHA
    3fe62e8 View commit details
    Browse the repository at this point in the history

  7. feat(Member): ✨ add Member#image_url 

    because this is different from User#avatar_url and I didn't know that at the time
    @not-so-smart
    not-so-smart committed May 23, 2022
    Configuration menu
    Copy the full SHA
    1376aed View commit details
    Browse the repository at this point in the history

  8. feat(Poll): 🍻 poll overhaul 

    (and extend `Base`)
    @not-so-smart
    not-so-smart committed May 23, 2022
    Configuration menu
    Copy the full SHA
    67f700b View commit details
    Browse the repository at this point in the history

  9. refactor(Managers): 🏷️ add type parameter for data constructors 

    this makes managers generic on their held data types AND the held data type's constructor. Also replaces the Indexable interface with the Base class, so BaseManager is now generic on Base instead of Indexable
    @not-so-smart
    not-so-smart committed May 23, 2022
    Configuration menu
    Copy the full SHA
    a3b3284 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into indexable-base

    @not-so-smart
    not-so-smart committed May 23, 2022
    Configuration menu
    Copy the full SHA
    882955c View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. fix: 🚨 replace avatar with avatar_url 

    missed this one somehow the first time around
    @not-so-smart
    not-so-smart committed May 27, 2022
    Configuration menu
    Copy the full SHA
    826ef0b View commit details
    Browse the repository at this point in the history

  2. chore: ⬆️ update dependencies 

    including groupme-api-types@2.0.0
    @not-so-smart
    not-so-smart committed May 27, 2022
    Configuration menu
    Copy the full SHA
    c0cf093 View commit details
    Browse the repository at this point in the history