Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global /tmp instead of writing into workspace #166

Merged
merged 1 commit into from
Sep 29, 2015

Conversation

jkrems
Copy link
Collaborator

@jkrems jkrems commented Sep 28, 2015

Cleanly separates a repository-level tmp/ directory from the global tmp directory used by npm. This fixes a regression where previous assumptions about the post-test state of the checkout (e.g. checks for a clean git status) started failing.

Cleanly separates a repository-level tmp/ directory from the global
tmp directory used by npm. This fixes a regression where previous
assumptions about the post-test state of the checkout (e.g. checks
for a clean `git status`) started failing.
@jcalzaretta
Copy link
Contributor

This is a good idea. It keeps the workspace clean while still enabling auditing of who's using /tmp on the build slaves via project namespacing.

suryagaddipati added a commit that referenced this pull request Sep 29, 2015
Use global /tmp instead of writing into workspace
@suryagaddipati suryagaddipati merged commit 58727e6 into groupon:master Sep 29, 2015
@suryagaddipati
Copy link
Contributor

Thank you

@jkrems jkrems deleted the jk-use-global-tmp branch September 29, 2015 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants