Skip to content

Commit

Permalink
fix: tweak default node/* settings
Browse files Browse the repository at this point in the history
* the unpublished-require checks is broken for the way we use devDeps
* the deprecated-api check shouldn't kill use of e.g.
    require('url')...for now
  • Loading branch information
dbushong committed Oct 26, 2019
1 parent a207b40 commit 6d3fd0f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lib/rules/mistakes.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,11 @@ module.exports = {

// See: https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unresolved.md
'import/no-unresolved': ['error', { commonjs: true, caseSensitive: true }],

// This does the same thing, but doesn't know about devDeps properly
// See: https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-unpublished-require.md
'node/no-unpublished-require': ['off'],

// See: https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-extraneous-dependencies.md
'import/no-extraneous-dependencies': [
'error',
Expand Down
3 changes: 3 additions & 0 deletions lib/rules/opinions.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,7 @@ module.exports = {

// See: https://eslint.org/docs/rules/object-shorthand
'object-shorthand': 'error',

// See: https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-deprecated-api.md
'node/no-deprecated-api': ['warn'],
};

0 comments on commit 6d3fd0f

Please sign in to comment.