Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface 'array' from SPIRType in spirv::Type #58

Merged
merged 2 commits into from
Mar 2, 2018
Merged

Surface 'array' from SPIRType in spirv::Type #58

merged 2 commits into from
Mar 2, 2018

Conversation

StrayLightning
Copy link
Contributor

Also adds a unit test for a simple array example.

StrayLightning added 2 commits February 28, 2018 10:36
Surface SPIRType array in spirv::Type
5b6bb66 
Note that this is a breaking change.

The unit tests have been updated, but there should be at least one new
unit test to cover the case where there is an array.
Add unit test of array dimensions in spirv::Type
62a5c22
@codecov
Copy link

codecov bot commented Mar 1, 2018 •
edited
Loading

Codecov Report

Merging #58 into master will decrease coverage by 0.89%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #58     +/-   ##
=========================================
- Coverage   71.23%   70.33%   -0.9%     
=========================================
  Files           5        5             
  Lines         584      600     +16     
=========================================
+ Hits          416      422      +6     
- Misses        168      178     +10
Impacted Files Coverage Δ
spirv_cross/src/spirv.rs 52.08% <0%> (-7.45%) ⬇️
spirv_cross/src/compiler.rs 71.32% <45%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c5d60...62a5c22. Read the comment docs.

grovesNL
grovesNL approved these changes Mar 2, 2018
View reviewed changes
Copy link
Owner

@grovesNL grovesNL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I hope the FFI parts weren't too confusing to modify 😄

bors r+

spirv_cross/src/compiler.rs

check!(sc_internal_free_pointer(raw.member_types as *mut c_void));
if raw.member_types_size > 0 {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bors bot added a commit that referenced this pull request Mar 2, 2018
@bors
Merge #58
1ea5fe0 
58: Surface 'array' from SPIRType in spirv::Type r=grovesNL a=StrayLightning

Also adds a unit test for a simple array example.
@bors
Copy link
Contributor

bors bot commented Mar 2, 2018

Build succeeded

@bors bors bot merged commit 62a5c22 into grovesNL:master Mar 2, 2018
@StrayLightning
Copy link
Contributor Author

Thanks! I managed not to tie either the commits or pull request to issue #43, but I'll try and correct that now.

@StrayLightning StrayLightning mentioned this pull request Mar 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grovesNL grovesNL grovesNL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StrayLightning @grovesNL