120946 121459 new top design latter #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-takei
requested changes
May 25, 2023
| height: 244px; | ||
| /* GROWI cloud section */ | ||
| .growi-cloud-bg { | ||
| background-color: #EFF7FC; |
There was a problem hiding this comment.
カラーコード直に書くのは避けたい。
bootstrap の primary/info/success を上書きするか、それ以外に用意したい場合も _variable.scss 等を用意してまとめてほしい。
There was a problem hiding this comment.
今のTOPページ動いてる分は_variable.scssに移行しました。
| background-repeat: no-repeat; | ||
| background-position: right -10% bottom -20px; | ||
| background-size: 70%; | ||
| @media (min-width: 992px) { |
There was a problem hiding this comment.
この辺も bootstrap way で書けるはず
There was a problem hiding this comment.
こちら理解できなかったので相談させてください。
@include media-breakpoint-up(lg) {...}
みたいに記述するのかなと解釈したのですがbootstrapのSassマップが見つからず、そのまま記載したりするとエラーに下記のドキュメントを_variables.scss _mixin.scssに入れても駄目でした。
やってること違ったら言ってください。
https://getbootstrap.jp/docs/5.0/layout/breakpoints/
There was a problem hiding this comment.
口頭でいただいた指示で解決できました。
$screen-mdで定義されていた(@media min-width:~)もlgかmdが最適かを見直しながら置換えました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
機能と特徴セクション
screen-shotごとfeaturesと入れ替えている導入のメリット
order-*でPC表示の順番を入れ替えレスポンシブ表示をしている.cloud CTA
order-*でPC表示の順番を入れ替えレスポンシブ表示をしているフッター
その他
.btn-hexagon-angle-rightが表示されなかったので修正Home.vue内の<style>は最小限にし、cloud関連のクラスはstyle.scssへ移動