Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.4.1 Improvements #40

Merged
merged 35 commits into from
Nov 8, 2023
Merged

2.4.1 Improvements #40

merged 35 commits into from
Nov 8, 2023

Conversation

bttf
Copy link
Contributor

@bttf bttf commented Oct 10, 2023 •
edited
Loading

Changes

  • Move everything to hooks
  • Improve on-hover frame behavior
  • Improve drag and drop

TODO

  • Bump growthbook JS SDK version

@bttf
Misc improvements
da05fa3
@bttf
Shorten finder length; Improve floating frame
0f14313
@bttf
Fix flicker issue
a7f1ffb
@bttf
Render overlay on selected element state; Get rid of MoveTag; Refine …
18226f7 
…z-indices
@bttf
Use popover instead; Add useFloatingAnchor hook
fa9738d
@bttf
Fix reload page button from appending to history
740303d
@bttf
Tweak overlay
d4654f6
@bttf
Restructure
79462ff
@bttf
Clean up; Move CustomJS and Global CSS to hooks
36bb523
@bttf
Move into separate util
7a7a601
@bttf
Clean up ErrorDisplay
c9513b7
@bttf
Delete useApi; Add useVisualChangeset and useAiCopySuggestion
538f410
@bttf
Mark TODOs
7fe83c8
@bttf
Update BackToGBButton
9c0056d
@bttf
Impl useEditMode
fb55c5d
@bttf
Get EditElementMenu in foundational state
90e3bd7
@bttf
Fix bug
21ee776
@bttf
Bump GB SDK
0558860
@bttf
useDragAndDrop
101e314
@bttf
No strict mode; Fix highlight behavior
0126e15
@bttf
Various fixes
aea0bf9
@bttf
Restore updated dom mutation list; Clean up drag destination
0a113c1
@bttf
Clean up selector display behavior
08ee053
@bttf
Allow dragging outside of parent element
fe22c34
@bttf
Fix weird selector behavior
54b9746
@bttf
Show floating undo button if mutations exist for selected element
1284ac5
@bttf
Coalesce consecutive position mutations on an element
88ebfdd
@bttf
Fix CSS from being overridden
676ff09
@bttf
Add MoveElementHandle
6fd84fc
@bttf
bump dom-mutator version
5063587
@bttf
Copy link
Contributor Author

bttf commented Oct 25, 2023 •
edited
Loading

New drag and drop UX

  • quick access undo button for selected elements with DOM mutations associated with it
  • 'move tag' to visually indicate element is moveable. element can be dragged by 'move tag' or by dragging element itself
Screenshot 2023-10-24 at 2 35 27 PM

@bttf
Copy link
Contributor Author

bttf commented Oct 25, 2023 •
edited
Loading

Implemented SDK warnings to ensure customers are using the latest SDK for visual experiments

When SDK is not detected at all
Screenshot 2023-10-25 at 4 25 46 PM

When SDK is detected but is not latest version
image

When SDK is detected and is latest
Screenshot 2023-10-25 at 4 23 06 PM

@bttf bttf merged commit 5a3a4e2 into main Nov 8, 2023
1 check passed
@bttf bttf deleted the adnan/2.4.1-improvements branch November 8, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bttf