Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.3 Bugfixes #52

Merged
merged 4 commits into from
Nov 21, 2023
Merged

3.3 Bugfixes #52

merged 4 commits into from
Nov 21, 2023

Conversation

bttf
Copy link
Contributor

@bttf bttf commented Nov 20, 2023 •
edited
Loading

Addresses a few issues caught in the wild.

Fixes:

  • undefined reference to sdk attributes
    • causes editor to crash when users have SDK loaded but have not set attributes
  • SDK version detector reporting wrong status
  • prevent CSP error messages that aren't relevant
  • make SDK detector listen for GB_REFRESH msg for reliability
  • remove front-facing SDK warning
    • users getting confused that something is wrong. basically moving all warnings / errors to DebugPanel so user can discover in a debug situation
Screenshot 2023-11-21 at 9 41 55 AM

@bttf bttf requested a review from jdorn November 21, 2023 14:52
@bttf bttf merged commit 8eeab09 into main Nov 21, 2023
1 check passed
@bttf bttf deleted the adnan/3.3-fixes branch November 21, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdorn jdorn Awaiting requested review from jdorn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bttf