Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize css flow #61

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Optimize css flow #61

merged 3 commits into from
Apr 4, 2024

Conversation

bttf
Copy link
Contributor

@bttf bttf commented Apr 4, 2024

Users were experiencing issues editing the Global CSS of a page. This was primarily due to two reasons:

  • the CSS saving pipeline was unoptimized (save requests made when no changes were effected)
  • we got rid of optimistic saving a while ago, and it has cause some minor degradation of quality in UX; global CSS showing the extreme case.

This PR addresses the above two issues. In addition, we remove the use of error codes and instead use actual error messages instead, which should be more helpful in support situations.

@bttf bttf merged commit 8c28444 into main Apr 4, 2024
1 check passed
@bttf bttf deleted the adnan/fix-global-css branch April 4, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant