REST API - Allow updating in-progress conversion, attribution model, …

…and stats engine for experiment settings (#2435)
growthbook · Apr 30, 2024 · 3f97efb · 3f97efb · github-actions · Apr 30, 2024
1 parent 6ed4d50
commit 3f97efb
Show file tree

Hide file tree

Showing 6 changed files with 85 additions and 4 deletions.
diff --git a/packages/back-end/generated/spec.yaml b/packages/back-end/generated/spec.yaml
diff --git a/packages/back-end/src/api/openapi/payload-schemas/PostExperimentPayload.yaml b/packages/back-end/src/api/openapi/payload-schemas/PostExperimentPayload.yaml
@@ -68,6 +68,21 @@ properties:
     type: string
   excludeFromPayload:
     type: boolean
+  inProgressConversions:
+    type: string
+    enum:
+      - loose
+      - strict
+  attributionModel:
+    type: string
+    enum:
+      - firstExposure
+      - experimentDuration
+  statsEngine:
+    type: string
+    enum:
+      - bayesian
+      - frequentist
   variations:
     type: array
     minItems: 2

diff --git a/packages/back-end/src/api/openapi/payload-schemas/UpdateExperimentPayload.yaml b/packages/back-end/src/api/openapi/payload-schemas/UpdateExperimentPayload.yaml
@@ -58,6 +58,21 @@ properties:
     type: string
   excludeFromPayload:
     type: boolean
+  inProgressConversions:
+    type: string
+    enum:
+      - loose
+      - strict
+  attributionModel:
+    type: string
+    enum:
+      - firstExposure
+      - experimentDuration
+  statsEngine:
+    type: string
+    enum:
+      - bayesian
+      - frequentist
   variations:
     type: array
     minItems: 2

diff --git a/packages/back-end/src/services/experiments.ts b/packages/back-end/src/services/experiments.ts
@@ -1800,8 +1800,9 @@ export function postExperimentApiPayloadToInterface(
     activationMetric: "",
     segment: "",
     queryFilter: "",
-    skipPartialData: false,
-    attributionModel: "firstExposure",
+    skipPartialData: payload.inProgressConversions === "strict",
+    attributionModel: payload.attributionModel || "firstExposure",
+    ...(payload.statsEngine ? { statsEngine: payload.statsEngine } : {}),
     variations:
       payload.variations.map((v) => ({
         ...v,
@@ -1854,6 +1855,9 @@ export function updateExperimentApiPayloadToInterface(
     variations,
     releasedVariationId,
     excludeFromPayload,
+    inProgressConversions,
+    attributionModel,
+    statsEngine,
   } = payload;
   return {
     ...(trackingKey ? { trackingKey } : {}),
@@ -1872,6 +1876,11 @@ export function updateExperimentApiPayloadToInterface(
     ...(status ? { status } : {}),
     ...(releasedVariationId !== undefined ? { releasedVariationId } : {}),
     ...(excludeFromPayload !== undefined ? { excludeFromPayload } : {}),
+    ...(inProgressConversions !== undefined
+      ? { skipPartialData: inProgressConversions === "strict" }
+      : {}),
+    ...(attributionModel !== undefined ? { attributionModel } : {}),
+    ...(statsEngine !== undefined ? { statsEngine } : {}),
     ...(variations
       ? {
           variations: variations?.map((v) => ({

diff --git a/packages/back-end/src/validators/openapi.ts b/packages/back-end/src/validators/openapi.ts
diff --git a/packages/back-end/types/openapi.d.ts b/packages/back-end/types/openapi.d.ts