Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API - Allow updating in-progress conversion, attribution model, and stats engine for experiment settings #2435

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

bttf
Copy link
Collaborator

@bttf bttf commented Apr 26, 2024

Closes #2184

@bttf bttf requested a review from lukesonnet April 26, 2024 22:03
Copy link

github-actions bot commented Apr 26, 2024

Deploy preview for docs ready!

✅ Preview
https://docs-56irvirxk-growthbook.vercel.app

Built with commit 48324f9.
This pull request is being automatically deployed with vercel-action

Copy link

Your preview environment pr-2435-bttf has been deployed.

Preview environment endpoints are available at:

Copy link
Contributor

@lukesonnet lukesonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like we need to add the same fields to the PostExperimentPayload and the same method in experiments.ts. Feel free to do so if you want to.

@bttf
Copy link
Collaborator Author

bttf commented Apr 30, 2024

LGTM. Seems like we need to add the same fields to the PostExperimentPayload and the same method in experiments.ts. Feel free to do so if you want to.

That makes sense. Let me add that

@bttf
Copy link
Collaborator Author

bttf commented Apr 30, 2024

Updated POST experiments endpoint w/ fields; tested both endpoints locally
Screenshot 2024-04-30 at 1 45 57 PM
Screenshot 2024-04-30 at 1 44 46 PM

@bttf bttf merged commit 3f97efb into main Apr 30, 2024
5 checks passed
@bttf bttf deleted the adnan/rest-api-exp-settings-stats-engine branch April 30, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Allow setting Experiment Analysis Settings on createExperiment and updateExperiment
2 participants