Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dependabot #373

Closed
wants to merge 1 commit into from
Closed

Added Dependabot #373

wants to merge 1 commit into from

Conversation

iamrajiv
Copy link
Contributor

Fixes: #275

@codecov-io
Copy link

codecov-io commented Dec 10, 2020

Codecov Report

Merging #373 (026f638) into master (4890039) will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage   73.19%   73.50%   +0.30%     
==========================================
  Files          41       41              
  Lines        1317     1317              
==========================================
+ Hits          964      968       +4     
+ Misses        299      295       -4     
  Partials       54       54              
Impacted Files Coverage Δ
retry/retry.go 75.77% <0.00%> (+2.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4890039...026f638. Read the comment docs.

Copy link

@yaronius yaronius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to v2 branch release 👍

@bwplotka
Copy link
Collaborator

Can we add this to v2 branch then? 🤗

@iamrajiv
Copy link
Contributor Author

@bwplotka Sure. Do I have to make a new PR against the v2 branch?

@bwplotka
Copy link
Collaborator

No, you can just rebase on v2

@iamrajiv iamrajiv changed the base branch from master to v2 January 1, 2021 15:03
@iamrajiv iamrajiv changed the base branch from v2 to master January 1, 2021 15:04
@iamrajiv iamrajiv changed the base branch from master to v2 January 1, 2021 15:09
@iamrajiv iamrajiv changed the base branch from v2 to master January 1, 2021 15:09
@iamrajiv iamrajiv closed this Jan 1, 2021
@iamrajiv
Copy link
Contributor Author

iamrajiv commented Jan 1, 2021

@bwplotka I was getting merge conflicts error in my local system while rebasing I think I messed up with the branches. I have created a new PR #376.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-grpc-middleware.v2: Action Plan.
4 participants