Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dependabot #376

Merged
merged 1 commit into from Jul 6, 2021
Merged

Added Dependabot #376

merged 1 commit into from Jul 6, 2021

Conversation

iamrajiv
Copy link
Contributor

@iamrajiv iamrajiv commented Jan 1, 2021

Fixes: #275

@codecov-io
Copy link

codecov-io commented Jan 1, 2021

Codecov Report

Merging #376 (1a1d689) into v2 (a79558a) will decrease coverage by 7.68%.
The diff coverage is 93.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #376      +/-   ##
==========================================
- Coverage   83.58%   75.90%   -7.69%     
==========================================
  Files          30       31       +1     
  Lines         932      776     -156     
==========================================
- Hits          779      589     -190     
- Misses        114      139      +25     
- Partials       39       48       +9     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/logging/payload.go 79.24% <50.00%> (-3.37%) ⬇️
interceptors/retry/retry.go 66.66% <70.00%> (-9.58%) ⬇️
interceptors/logging/interceptors.go 100.00% <100.00%> (ø)
interceptors/logging/logging.go 61.53% <100.00%> (-6.21%) ⬇️
interceptors/ratelimit/ratelimit.go 100.00% <100.00%> (ø)
interceptors/tags/fieldextractor.go 82.75% <100.00%> (-2.54%) ⬇️
interceptors/tracing/id_extract.go 76.92% <100.00%> (-8.27%) ⬇️
wrappers.go 50.00% <0.00%> (-50.00%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6bf00...1a1d689. Read the comment docs.

@iamrajiv iamrajiv mentioned this pull request Jan 1, 2021
@yashrsharma44
Copy link
Collaborator

Tests are failing due to an unrelated data race. I thought that would have been fixed by this - #354 😟

@codecov-commenter
Copy link

Codecov Report

Merging #376 (1a1d689) into v2 (a79558a) will decrease coverage by 7.68%.
The diff coverage is 93.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #376      +/-   ##
==========================================
- Coverage   83.58%   75.90%   -7.69%     
==========================================
  Files          30       31       +1     
  Lines         932      776     -156     
==========================================
- Hits          779      589     -190     
- Misses        114      139      +25     
- Partials       39       48       +9     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/logging/payload.go 79.24% <50.00%> (-3.37%) ⬇️
interceptors/retry/retry.go 66.66% <70.00%> (-9.58%) ⬇️
interceptors/logging/interceptors.go 100.00% <100.00%> (ø)
interceptors/logging/logging.go 61.53% <100.00%> (-6.21%) ⬇️
interceptors/ratelimit/ratelimit.go 100.00% <100.00%> (ø)
interceptors/tags/fieldextractor.go 82.75% <100.00%> (-2.54%) ⬇️
interceptors/tracing/id_extract.go 76.92% <100.00%> (-8.27%) ⬇️
wrappers.go 50.00% <0.00%> (-50.00%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6bf00...1a1d689. Read the comment docs.

@iamrajiv
Copy link
Contributor Author

@yashrsharma44 I think this can be merged now.

Copy link
Collaborator

@yashrsharma44 yashrsharma44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @johanbrandhorst can we get this merged?

@bwplotka
Copy link
Collaborator

bwplotka commented Jul 6, 2021

Let's try it out. Thanks!

@bwplotka bwplotka merged commit 028d350 into grpc-ecosystem:v2 Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants