Golang implementation #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed a mistake; I'll fix it today. |
gnossen
approved these changes
Mar 23, 2020
| --platform=managed \ | ||
| --format="value(status.address.url)" \ | ||
| --filter="metadata.name=grpc-calculator") | ||
| ENDPOINT=${ENDPOINT#https://} && echo ${ENDPOINT} |
There was a problem hiding this comment.
Nit: It would be nice to have this in the other two README files as well.
There was a problem hiding this comment.
I've created a branch in my repo with the changes for the other languages
|
@DazWilkin Looks like there's a conflict that needs to be resolved in |
|
@gnossen it's a consistency recommendation. I'm unable to 'Resolve conflicts' but you may be able to do so.... The change ensures all flags are |
|
FYI, in the future, you can resolve yourself with git fetch origin
git merge origin/master |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #11