Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement detailed specs of google.api.http #14

Merged
merged 10 commits into from
May 21, 2015

Conversation

yugui
Copy link
Member

@yugui yugui commented May 9, 2015

This is a follow-up PR of #12.

It reflects the detailed specs of the new custom option shown by Wolfgang to our implementation.

@philips
Copy link

philips commented May 17, 2015

It took me some time to figure out what google.api.http is, but it is this: https://github.com/google/googleapis/blob/master/google/api/http.proto

@dmitshur
Copy link
Contributor

@philips, you can find relevant background information the description of PR #12.

yugui added 4 commits May 18, 2015 21:24
* Use internal.DoubleArray to reduce time complexity.
* Replace github.com/ajg/form with a custom impl because:
  1. proto messages do not have "form" struct tag, thus they does not
     fit to the library very well.
  2. field paths in google.api.http does not support so complex path
     that we need the library.
@yugui yugui changed the title [WIP] Implement detailed specs of google.api.http Implement detailed specs of google.api.http May 20, 2015
@hayate
Copy link

hayate commented May 20, 2015

👍 LGTM

yugui added a commit that referenced this pull request May 21, 2015
Implement detailed specs of google.api.http
@yugui yugui merged commit 864bdec into master May 21, 2015
@yugui yugui deleted the feature/google-http-rule-more branch August 15, 2015 23:32
ithinker1991 referenced this pull request in tronprotocol/grpc-gateway Apr 26, 2018
add change getBalance to GetAcconts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method parameter in query string
4 participants