Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for more well known types in descriptor #809

Merged

Conversation

mayankcpdixit
Copy link
Contributor

This change is to support more wellknown types in "protoc-gen-grpc-gateway". It solves the following issue:
Ref: #808

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@codecov-io
Copy link

Codecov Report

Merging #809 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #809   +/-   ##
======================================
  Coverage    53.3%   53.3%           
======================================
  Files          30      30           
  Lines        3371    3371           
======================================
  Hits         1797    1797           
  Misses       1399    1399           
  Partials      175     175
Impacted Files Coverage Δ
protoc-gen-grpc-gateway/descriptor/types.go 41.08% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c0cd0...99a9425. Read the comment docs.

@mayankcpdixit
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@achew22 achew22 merged commit 1659831 into grpc-ecosystem:master Nov 14, 2018
johanbrandhorst added a commit that referenced this pull request Nov 15, 2018
johanbrandhorst added a commit that referenced this pull request Nov 16, 2018
johanbrandhorst added a commit that referenced this pull request Nov 16, 2018
* Revert "Adding support for more well known types in descriptor (#809)"

This reverts commit 1659831.
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
…-ecosystem#813)

* Revert "Adding support for more well known types in descriptor (grpc-ecosystem#809)"

This reverts commit 1659831.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants