Revert "Adding support for more well known types in descriptor" #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
======================================
Coverage 53.3% 53.3%
======================================
Files 30 30
Lines 3371 3371
======================================
Hits 1797 1797
Misses 1399 1399
Partials 175 175
Continue to review full report at Codecov.
|
|
hey @johanbrandhorst :) i'm working currently on related changes as well, and well on my local branch i have exactly these changes (adding the missing WKN-types to this map) as well.. |
|
This was reverted because the function signatures weren't correct. We want to add this, but we need to add some tests and make sure it all plumbs together. Please feel free to submit a PR with the changes. |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
…-ecosystem#813) * Revert "Adding support for more well known types in descriptor (grpc-ecosystem#809)" This reverts commit 1659831.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #809