marshal_jsonpb: add check for slice sub types implementing proto.Message #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #856 +/- ##
==========================================
+ Coverage 51.63% 51.66% +0.03%
==========================================
Files 39 39
Lines 3788 3807 +19
==========================================
+ Hits 1956 1967 +11
- Misses 1647 1651 +4
- Partials 185 189 +4
Continue to review full report at Codecov.
|
johanbrandhorst
requested changes
Jan 21, 2019
johanbrandhorst
approved these changes
Jan 21, 2019
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
…age (grpc-ecosystem#856) * marshal_jsonpb: add check for slice sub types implementing proto.Message * Added more tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the slice of response bodies, even if they implement
proto.Messageare still being marshalled using the default json marshaller and ignoring theEnumsAsIntsflag. I've updated the implementation to handle this case, and pass off each individual object in the slice to the jsonpb marshaller.Let me know if there's a better way of handling these slice types that I'm missing.
Thanks!