Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: add protobuf accessors for better nil-safety #17

Merged
merged 1 commit into from
Feb 10, 2023
Merged

cmd: add protobuf accessors for better nil-safety #17

merged 1 commit into from
Feb 10, 2023

Conversation

dfawley
Copy link
Collaborator

@dfawley dfawley commented Feb 7, 2023

Fixes #16

cc @veblush

There are no tests, but this passes go build ./...

@dfawley dfawley added the bug Something isn't working label Feb 7, 2023
@dfawley dfawley requested a review from ejona86 February 7, 2023 17:59
ejona86
ejona86 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we get the idea.

@ejona86 ejona86 merged commit 0d7ddd0 into grpc-ecosystem:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees

@ejona86 ejona86

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when running channelz channels
2 participants
@dfawley @ejona86