Get dependencies from original symbol or file lookup #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow skipping check_method_available * When descriptors are looked up by symbol, use the file descriptors returned in dependency resolution Signed-off-by: Aidan Jensen <aidan@artificial.com>
artificial-aidan
force-pushed
the
aidan/get-dependencies-from-symbol-lookup
branch
from
985a251
to
386a868
Compare
Signed-off-by: Aidan Jensen <aidan@artificial.com>
artificial-aidan
force-pushed
the
aidan/get-dependencies-from-symbol-lookup
branch
from
eea5110
to
40b249b
Compare
|
@artificial-aidan - just wanted to let you know that I'll give this a thorough review tomorrow night. Thanks for all this work! |
Signed-off-by: Aidan Jensen <aidan@artificial.com>
Signed-off-by: Aidan Jensen <aidan@artificial.com>
Signed-off-by: Aidan Jensen <aidan@artificial.com>
|
@ViridianForge Cleaned some stuff up, addressed comments, and added a sync implementation |
ViridianForge
approved these changes
Feb 15, 2024
|
That's all for now! Thanks for reviewing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background here: grpc/grpc#32899
The logic isn't my best work, so definitely open to input on that. The gist of it is to use the file descriptor protos that are returned in the dependency resolution, but the spec didn't specify an order, so I had to do extra logic around lookup. I may go look at how other languages to it, to see if they unofficially assume the order of dependencies will be correct.
This is just the async side, if the feedback is good I'm happy to port it to the sync side as well.
Another change I made was for the test files. I used an empty descriptor pool for the client creation, I found that the descriptors were already loaded, and the test's weren't actually exercising the lookup functionality. I believe this is because the test process loads the server, which loads the protos into its pool. By using an empty pool for the client, we force the exercising of the lookup mechanisms.
Additionally, an optional
skip_check_method_availablewas added to the clients. This follows the above in trying to optimize the speed at which we can reflect and call a method.