Reflection integration #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
commented
Apr 2, 2019
src/Grpc.AspNetCore.Server/GrpcEndpointRouteBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
JamesNK
commented
Apr 2, 2019
examples/Server/Startup.cs
Outdated
| @@ -40,6 +41,7 @@ public void Configure(IApplicationBuilder app) | |||
| routes.MapGrpcService<MailerService>(); | |||
| routes.MapGrpcService<CounterService>(); | |||
| routes.MapGrpcService<GreeterService>(); | |||
| routes.MapGrpcReflectionService(); | |||
There was a problem hiding this comment.
Adding reflection on the server:
services.AddGrpcReflection();plus
services.MapGrpcReflectionService();Clean! 😄
jtattermusch
approved these changes
Apr 5, 2019
src/Grpc.AspNetCore.Server.Reflection/Grpc.AspNetCore.Server.Reflection.csproj
Outdated
Show resolved
Hide resolved
src/Grpc.AspNetCore.Server/GrpcEndpointRouteBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
JamesNK
force-pushed
the
jamesnk/reflection
branch
from
8334d80
to
2740d80
Compare
JamesNK
force-pushed
the
jamesnk/reflection
branch
from
703adad
to
bb5140b
Compare
|
I've rewritten this slightly to use endpoints + metadata to get the services instead of a new registry. |
|
@JunTaoLuo ping. Review please |
JunTaoLuo
reviewed
Apr 23, 2019
test/Grpc.AspNetCore.Server.Tests/Grpc.AspNetCore.Server.Tests.csproj
Outdated
Show resolved
Hide resolved
JunTaoLuo
reviewed
Apr 23, 2019
JunTaoLuo
reviewed
Apr 23, 2019
src/Grpc.AspNetCore.Server.Reflection/GrpcReflectionServiceExtensions.cs
Outdated
Show resolved
Hide resolved
JunTaoLuo
reviewed
Apr 23, 2019
src/Grpc.AspNetCore.Server.Reflection/GrpcEndpointRouteBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
JunTaoLuo
reviewed
Apr 23, 2019
src/Grpc.AspNetCore.Server.Reflection/Internal/ReflectionGrpcServiceActivator.cs
Show resolved
Hide resolved
JunTaoLuo
reviewed
Apr 23, 2019
|
I'll add a couple of tests, just to sanity check that it still works. |
JunTaoLuo
approved these changes
Apr 25, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces Grpc.AspNetCore.Server.Reflection. It provides a reflection integration with gRPC for ASP.NET.
It is a separate package because it depends on Grpc.Reflection, and Grpc.Reflection has a dependency on Grpc.Core. If we want to avoid an extra package then we could re-implement the server component of Grpc.Reflection, eliminate the dependency and build everything into Grpc.AspNetCore.Server.
Done now to figure out how to access the service descriptor using reflection for grpc/grpc#18484