wrr: add EDF implementation of weighted round robin. #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a pending PR #2950 to refactor the current xds code in grpc/balancer/xds to grpc/xds/balancer. Do you plan to use the EDF implementation in this PR from outside of xds code? Please let me know. |
|
@easwars Yes, I'm going to use EDF implementation from balancer/weightedroundrobin/weightedroundrobin.go |
|
Thanks @alazarev for your reply. |
easwars
added a commit
to easwars/grpc-go
that referenced
this pull request
Aug 6, 2019
There is a pending PR (grpc#2957) which wants to use the wrr package from balancer/weightedroundrobin/weightedroundrobin.go. Moving the package to internal/wrr would make it accessible to both xds and balancer code.
EDF is strictly better than current random based wrr (balancer/internal/wrr/random.go). It can be used to load balance both between balancer groups (balancer/xds/edsbalancer/balancergroup.go) and within balancer group using weighted round robin balancer implementation (comming in the next pull request for grpc#2827).
|
Picked up #2950 changes. |
menghanl
reviewed
Aug 8, 2019
|
It looks like CI failure on go1.11 is in internal/transport and not related to PR |
menghanl
changed the title
menghanl
approved these changes
Aug 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDF is strictly better than current random based wrr (balancer/internal/wrr/random.go).
It can be used to load balance between balancer groups (balancer/xds/edsbalancer/balancergroup.go) and
within balancer group using weighted round robin balancer implementation (coming in the next pull request for #2827).