Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: use generated protos from github.com/cncf/udpa/go #3449

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

neild
Copy link
Contributor

@neild neild commented Mar 12, 2020

The upstream repo contains generated Go packages, so there's no need to
generate a separate version here.

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@dfawley
Copy link
Member

dfawley commented Mar 12, 2020

Oops. Looks like github.com/envoyproxy/protoc-gen-validate is no longer needed. Can you run go mod tidy please?

The upstream repo contains generated Go packages, so there's no need to
generate a separate version here.
@neild
Copy link
Contributor Author

neild commented Mar 12, 2020

Oops. Looks like github.com/envoyproxy/protoc-gen-validate is no longer needed. Can you run go mod tidy please?

Done.

@menghanl menghanl merged commit 197c621 into grpc:master Mar 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants