Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: stabilize WithConnectParams DialOption #4915

Merged
merged 1 commit into from Nov 3, 2021

Conversation

hypnoglow
Copy link
Contributor

@hypnoglow hypnoglow commented Oct 31, 2021

As proposed per #4461, this change removes comments stating that WithConnectParams API is still experimental.

Please let me know if we need to adjust any commentary for this function or change anything else.

Closes #4461

RELEASE NOTES:

  • grpc: stabilize WithConnectParams DialOption

@hypnoglow
Copy link
Contributor Author

@hypnoglow hypnoglow commented Oct 31, 2021

/assign @easwars

@zasweq zasweq added this to the 1.43 release milestone Nov 2, 2021
@zasweq zasweq requested a review from easwars Nov 2, 2021
easwars
easwars approved these changes Nov 2, 2021
@easwars easwars added the Type: Documentation label Nov 2, 2021
@easwars easwars assigned dfawley and unassigned easwars Nov 2, 2021
@easwars
Copy link
Contributor

@easwars easwars commented Nov 2, 2021

Assigning to @dfawley for second eyes.

dialoptions.go Show resolved Hide resolved
@dfawley dfawley requested a review from menghanl Nov 2, 2021
@dfawley
Copy link
Contributor

@dfawley dfawley commented Nov 2, 2021

@menghanl any concerns or objections?

@hypnoglow hypnoglow force-pushed the 4461-stabilize-WithConnectParams branch from e072b1c to 62f3162 Compare Nov 3, 2021
@hypnoglow hypnoglow requested a review from dfawley Nov 3, 2021
dfawley
dfawley approved these changes Nov 3, 2021
dialoptions.go Show resolved Hide resolved
@dfawley dfawley changed the title Stabilize WithConnectParams DialOption grpc: stabilize WithConnectParams DialOption Nov 3, 2021
@dfawley dfawley merged commit 3b94303 into grpc:master Nov 3, 2021
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants