Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: don't fail channel/server startup when xds creds is specified, but bootstrap is missing certificate providers #6848

Merged
merged 7 commits into from
Dec 20, 2023

review comments pass 2

25050b6
Select commit
Loading
Failed to load commit list.
Merged

xds: don't fail channel/server startup when xds creds is specified, but bootstrap is missing certificate providers #6848

review comments pass 2
25050b6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Dec 20, 2023 in 0s

14.28% of diff hit (target 83.43%)

View this Pull Request on Codecov

14.28% of diff hit (target 83.43%)

Annotations

Check warning on line 245 in xds/internal/balancer/cdsbalancer/cdsbalancer.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/internal/balancer/cdsbalancer/cdsbalancer.go#L243-L245 

Added lines #L243 - L245 were not covered by tests

Check warning on line 140 in xds/internal/server/conn_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/internal/server/conn_wrapper.go#L138-L140 

Added lines #L138 - L140 were not covered by tests
View more details on Codecov