Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: don't fail channel/server startup when xds creds is specified, but bootstrap is missing certificate providers #6848

Merged
merged 7 commits into from
Dec 20, 2023

review comments pass 2

25050b6
Select commit
Loading
Failed to load commit list.
Merged

xds: don't fail channel/server startup when xds creds is specified, but bootstrap is missing certificate providers #6848

review comments pass 2
25050b6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 20, 2023 in 1s

83.53% (+0.09%) compared to 52baf16

View this Pull Request on Codecov

83.53% (+0.09%) compared to 52baf16

Details

Codecov Report

Merging #6848 (25050b6) into master (52baf16) will increase coverage by 0.09%.
Report is 12 commits behind head on master.
The diff coverage is 14.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6848      +/-   ##
==========================================
+ Coverage   83.43%   83.53%   +0.09%     
==========================================
  Files         286      286              
  Lines       30801    30756      -45     
==========================================
- Hits        25699    25692       -7     
+ Misses       4028     3993      -35     
+ Partials     1074     1071       -3     
Files Coverage Δ
xds/internal/resolver/xds_resolver.go 78.93% <ø> (-0.04%) ⬇️
xds/internal/server/listener_wrapper.go 67.88% <ø> (-0.15%) ⬇️
xds/server.go 86.50% <ø> (+0.51%) ⬆️
xds/internal/balancer/cdsbalancer/cdsbalancer.go 80.80% <25.00%> (+0.43%) ⬆️
xds/internal/server/conn_wrapper.go 71.64% <0.00%> (-1.97%) ⬇️

... and 18 files with indirect coverage changes