-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: move from github.com/golang/protobuf to google.golang.org/protobuf/proto #6919
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
da3facf
move from github.com/golang/protobuf to google.golang.org/protobuf/proto
Clement-Jean 406e577
durationpb.New
Clement-Jean ebdb1c4
rename convertToDuration to durationToSecUsec
Clement-Jean a3f426c
refactor durationToSecUsec
Clement-Jean d64177a
use durationToSecUsec
Clement-Jean 304731b
refactor durationToSecUsec
Clement-Jean fa6e930
Simplify CheckValid
Clement-Jean 949ef0f
nix newlines
Clement-Jean 60e45ed
tidy
Clement-Jean 9b220f9
tidy
Clement-Jean f58f647
revert changes in channelz
Clement-Jean 54e1afb
add compatibility test for status
Clement-Jean e7e8143
Merge branch 'master' into remove_old_proto_pkg
Clement-Jean e6c2829
remove unused imports
Clement-Jean 3123478
add copyright
Clement-Jean 34b7bf8
add newline at EOF
Clement-Jean 47c76ef
move from github.com/golang/protobuf to google.golang.org/protobuf/proto
Clement-Jean 69fd411
durationpb.New
Clement-Jean 83b6619
rename convertToDuration to durationToSecUsec
Clement-Jean 2a0052d
refactor durationToSecUsec
Clement-Jean 3dcd777
use durationToSecUsec
Clement-Jean 28634a4
refactor durationToSecUsec
Clement-Jean 9c948d0
Simplify CheckValid
Clement-Jean 58ad782
revert changes in channelz
Clement-Jean 126c055
get up to date bootstrap.go
Clement-Jean f048283
tidy
Clement-Jean 92f0721
add sum file
Clement-Jean b9e8c68
fix: imported more than once error
Clement-Jean 6683fac
Merge branch 'grpc:master' into remove_old_proto_pkg
Clement-Jean c784e0a
WithDetails taking protoadapt.MessageV1
Clement-Jean 8024719
Merge remote-tracking branch 'refs/remotes/origin/remove_old_proto_pk…
Clement-Jean 4dd29b8
Merge branch 'master' into remove_old_proto_pkg
Clement-Jean 3ad5b8f
rm unused import
Clement-Jean 787304b
rm whitespace
Clement-Jean a3da2fc
Merge branch 'master' into remove_old_proto_pkg
dfawley ef83599
fix format
dfawley b837411
resolve conflicts and add changes
Clement-Jean File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the previous PR: I'm still fairly sure this is a breaking API change.
The function
WithDetails
needs to now accept aprotoadapt.MessageV1
now instead of aproto.Message
, because the new package'sproto.Message
is incompatible with the old one.This would impact anyone using proto messages generated by some other tool, like (IIUC)
gogoproto
. Or possibly(?) using a message generated by an oldprotoc-gen-go
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Clement-Jean -- This seems to be still unresolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird. It was fixed in this commit but now it's been reverted...
c784e0a
(#6919)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Clement-Jean @dfawley Are we not resolving this issue? Things are breaking with this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is 6 months old now. Please file a new issue with all the relevant details if you're seeing problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajat-agarwal1 I'd be happy to help with the issue if you open a new issue and tag me