protoc: Change protoc to include generated call option #6924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6924 +/- ##
==========================================
+ Coverage 83.51% 83.72% +0.20%
==========================================
Files 287 287
Lines 30920 30920
==========================================
+ Hits 25824 25887 +63
+ Misses 4020 3975 -45
+ Partials 1076 1058 -18 |
|
Discussed offline; closing this as we decided to add an exported call option from gRPC, release it, and use that symbol in generated code. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a call option in the generated code that can be used by stats handlers to determine whether a call comes from a registered method or not.
RELEASE NOTES: